Skip to content

Commit

Permalink
CLI: Actual locally tested fix to race condition
Browse files Browse the repository at this point in the history
Sorry for making new releases like this. It's that the live Browsh
services will only pull in officially released versions. But also that
this bug could affect a lot of people installing Browsh themselves.
  • Loading branch information
tombh committed Jun 19, 2019
1 parent 4ca05b9 commit 08c5ee8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions interfacer/src/browsh/firefox.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"net"
"os"
"os/exec"
"path"
"regexp"
"runtime"
"strings"
Expand Down Expand Up @@ -230,12 +231,10 @@ func installWebextension() {
if err != nil {
Shutdown(err)
}
file, err := ioutil.TempFile(os.TempDir(), "browsh-webext-addon")
ioutil.WriteFile(file.Name(), []byte(data), 0644)
args := map[string]interface{}{"path": file.Name()}
path := path.Join(os.TempDir(), "browsh-webext-addon")
ioutil.WriteFile(path, []byte(data), 0644)
args := map[string]interface{}{"path": path}
sendFirefoxCommand("Addon:Install", args)
time.Sleep(100 * time.Millisecond)
defer os.Remove(file.Name())
}

// Set a Firefox preference as you would in `about:config`
Expand Down
2 changes: 1 addition & 1 deletion interfacer/src/browsh/version.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package browsh

var browshVersion = "1.6.3"
var browshVersion = "1.6.4"

0 comments on commit 08c5ee8

Please sign in to comment.