Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework PNG Icon with SVG and SCSS #97

Closed
wants to merge 1 commit into from
Closed

Rework PNG Icon with SVG and SCSS #97

wants to merge 1 commit into from

Commits on Nov 29, 2021

  1. Rework PNG Icon with SVG and SCSS 

    Existing implementation using `icon-fullscreen.png` and
`icon-fullscreen-2x.png` for different screen (e.g. iOS with retina
display). Moreover, we don't have any toggle effect for the icon status.

This PR rework the icon with:
* Locally vendor Font Awesome v5.15.4 `compress-solid.svg` and
  `expand-solid.svg`
* Add default content for icon
* Add toggle status for icon
* Rework style with SCSS
* Create minified version JS and CSS
* Simplify demo and README.md with above changes

Some style reuse from: domoritz/leaflet-locatecontrol#296

Online demo: https://drustack.github.io/brunob-leaflet.fullscreen/

Fix brunob#87

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
    @hswong3i
    hswong3i committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    e321136 View commit details
    Browse the repository at this point in the history