This repository has been archived by the owner on May 15, 2023. It is now read-only.
Remove unnecessary use of #[repr(packed)].
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This struct is laid out the same way with or without `packed`, since it's just a few bytes. The removal is good because there's some correctness issues with it, so there may be breaking changes to it in future and removing it now will avoid them all together. See rust-lang/rust#27060.
bryal
added a commit
that referenced
this pull request
Jul 24, 2015
Remove unnecessary use of `#[repr(packed)]`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct is laid out the same way with or without
packed, sinceit's just a few bytes.
The removal is good because there's some correctness issues with it, so
there may be breaking changes to it in future and removing it now will
avoid them all together. See
rust-lang/rust#27060.