Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less restrictive convenience hashing functions #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Less restrictive convenience hashing functions #35

wants to merge 2 commits into from

Conversation

phil-k8r
Copy link

@phil-k8r phil-k8r commented Apr 4, 2018

Argon2::hash() accepts &[u8] as password and salt.
argon2d_simple() and argon2i_simple() accept &str as password and salt
and convert them to &[u8].

Instead of the conversion, argon2d_simple() and argon2i_simple() could accept
types that implement AsRef<[u8]> or &[u8] directly.

Accept types that implement AsRef<u8>
instead of &str as password and salt.
Make types of `password` and `salt` independent of each other and
accept `Unsize`d types.
FauxFaux added a commit to FauxFaux/argon2min that referenced this pull request Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant