Invalidated parent pointers if child array is reallocated

[tbeu]

During parsing, if in XmlNode_createChild cpo_array_preallocate is called by cpo_array_push in line

bsxml-json/bsxml.c

Line 186 in 981ab94

XmlNodeRef child = cpo_array_push( node->m_childs );

the m_parent pointer is invalidated (due to the realloc) for all grand-children of that node.

To reproduce: This happens with the attached xml file, where dummyRoot/set1 has 9 (> XMLTREE_CHILDSIZE = 8) children. When XmlNode_createChild is called for dummyRoot/set1/clock8 the m_parent gets invalidated for dummyRoot/gain/k etc.

testFAIL.zip

Currently, I have no patch for this, just the workaround to not use the parent pointer at all.

Furthermore, the reallocated memory in cpo_array_preallocate should also be nullified (similar as cpo_array_create calls calloc for a->v).

--- "a/array.c"
+++ "b/array.c"
@@ -54,6 +54,7 @@ static int cpo_array_preallocate(cpo_array_t *a, asize_t elements)
         free(a->v);
 
     a->v = newv;
+    memset((unsigned char*) a->v + a->elem_size * a->max, 0, (newmax - a->max) * a->elem_size);
     a->max = newmax;
     return 0;
 } 

See modelica-3rdparty/ExternData#26 for the downstream issue.