Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename Address Count to Host Addresses #91

Merged
merged 1 commit into from
Jan 8, 2024
Merged

chore: rename Address Count to Host Addresses #91

merged 1 commit into from
Jan 8, 2024

Conversation

bschaatsbergen
Copy link
Owner

@bschaatsbergen bschaatsbergen commented Jan 5, 2024 •
edited
Loading

What

  • Renamed Address Count: in the explain output to Host Addresses.

Why

  • To avoid any misunderstandings, the number indicates the count of host addresses as we subtract 2 to account for the base address and the broadcast address.

References

@bschaatsbergen
Copy link
Owner Author

@mmourick what are your thoughts on this change?

mmourick
mmourick approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@mmourick mmourick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the original wording was misleading. The proposed change is definitely an improvement.

@bschaatsbergen bschaatsbergen merged commit 33a4efd into main Jan 8, 2024
5 checks passed
@bschaatsbergen bschaatsbergen deleted the c/improve-explain-output branch January 8, 2024 19:43
@TajangSec
Copy link

I'm in favour of this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmourick mmourick mmourick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the total number of IPs and the total number of available IPs
3 participants
@bschaatsbergen @TajangSec @mmourick