Store the last error when fetching details.

When fetching the detailed bulk build report and there is an error,
store the error in the database and surface it on the build page.

There is more to be done here (including a better UI) but this at least
shows that there has been a problem.

Update #5

ingest/ingest.go

@@ -23,6 +23,8 @@
 package ingest
 
 import (
+	"database/sql"
+
 	"github.com/bsiegert/BulkTracker/bulk"
 	"github.com/bsiegert/BulkTracker/ddao"
 	"github.com/bsiegert/BulkTracker/log"
@@ -247,6 +249,13 @@ func (i *IncomingMailHandler) FetchReport(ctx context.Context, buildID int64, ur
 		status.LastErr = err
 		status.Current = Failed
 		status.Put(ctx)
+		i.DB.SetBuildLastError(ctx, ddao.SetBuildLastErrorParams{
+			BuildID: buildID,
+			LastError: sql.NullString{
+				Valid:  true,
+				String: fmt.Sprintf("failed to fetch: %s", err),
+			},
+		})
 		return
 	}
 	defer resp.Body.Close()
@@ -256,6 +265,13 @@ func (i *IncomingMailHandler) FetchReport(ctx context.Context, buildID int64, ur
 		status.LastErr = err
 		status.Current = Failed
 		status.Put(ctx)
+		i.DB.SetBuildLastError(ctx, ddao.SetBuildLastErrorParams{
+			BuildID: buildID,
+			LastError: sql.NullString{
+				Valid:  true,
+				String: fmt.Sprintf("failed to uncompress: %s", err),
+			},
+		})
 		return
 	}
 	pkgs, err := bulk.PkgsFromReport(r)
@@ -264,6 +280,13 @@ func (i *IncomingMailHandler) FetchReport(ctx context.Context, buildID int64, ur
 		status.LastErr = err
 		status.Current = Failed
 		status.Put(ctx)
+		i.DB.SetBuildLastError(ctx, ddao.SetBuildLastErrorParams{
+			BuildID: buildID,
+			LastError: sql.NullString{
+				Valid:  true,
+				String: fmt.Sprintf("failed to parse: %s", err),
+			},
+		})
 		return
 	}
 

queries.sql

@@ -134,3 +134,11 @@ VALUES (?, ?);
 INSERT INTO results
 (build_id, pkg_id, pkg_name, build_status, breaks, failed_deps)
 VALUES (?, ?, ?, ?, ?, ?);
+
+-- name: SetBuildLastError :exec
+
+-- SetBuildLastError sets the last_error column on a given build.
+UPDATE builds
+SET last_error = ?
+WHERE build_id = ?;
+

schema.sql

@@ -31,9 +31,14 @@ CREATE TABLE IF NOT EXISTS builds (
     num_prefailed INTEGER NOT NULL,
     num_failed INTEGER NOT NULL,
     num_indirect_failed INTEGER NOT NULL,
-    num_indirect_prefailed INTEGER NOT NULL    
+    num_indirect_prefailed INTEGER NOT NULL,
+
+    last_error text
 );
 
+-- Schema update:
+-- ALTER TABLE builds ADD COLUMN last_error text;
+
 CREATE TABLE IF NOT EXISTS pkgs (
     pkg_id INTEGER PRIMARY KEY ASC,
     category text NOT NULL,
@@ -55,4 +60,4 @@ CREATE TABLE IF NOT EXISTS results (
     breaks INTEGER NOT NULL
 );
 
-CREATE INDEX results_i_build_pkg ON results (build_id, pkg_id);
+CREATE INDEX results_i_build_pkg ON results (build_id, pkg_id);

templates/bulk_build_info.html

@@ -16,6 +16,12 @@
 		<a href="{{.ReportUrl}}">{{.ReportUrl}}</a>
 	  </dd>
 	  {{end}}
+	  {{if .LastError.Valid}}
+	  <dt>Last error</dt>
+	  <dd style = "color: red">
+		{{.LastError.String}}
+	  </dd>
+	  {{end}}
 	</dl>
       </div>
       <div class="col-md-3">