Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.9 update and gradle tweaks #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1.8.9 update and gradle tweaks #26

wants to merge 1 commit into from

Conversation

Lunatrius
Copy link

Update .git* files
Update gradle script and wrapper
Replace version checking with Forge version checking
Remove deprecated/unused classes

This PR is also a prerequisite for:

Some of the common changes:

  • .git* files: should make sure line endings are the same for everyone editing the code, organized the ignore list a bit
  • build.gradle:
    • config -> project: gradle automagically reads the properties from gradle.properties into the properties object
    • updated ForgeGradle, added CurseGradle
      • api_key_curse: defined in the global gradle properties file (usually ~/.gradle/gradle.properties)
      • extra_curse_id and extra_curse_releasetype: defined in the project's gradle.properties, release type is optional
  • all mods use Forge's version checking system - the URLs point to http://bspk.rs/Minecraft/<modid>.json

Version file format:

{
    "homepage": "http://whatever.com/",
    "promos": {
        "1.8.9-latest": "8.7",
        "1.8.9-recommended": "8.6.1"
    },
    // change logs, entirely optional
    "1.8.9": {
        "8.3": "update thing",
        "8.3.1": "update that",
        "8.4": "update this",
        "8.5": "remove that",
        "8.6": "add that\nadd something",
        "8.6.1": "remove something",
        "8.7": "change that"
    }
}

Update .git* files
Update gradle script and wrapper
Replace version checking with Forge version checking
Remove deprecated/unused classes (BSConfiguration, ModVersionCheck)
@BlueAnanas
Copy link

Just to make sure that you're aware that I shamelessly used your PR in my Update 1.9 #29

BTW, I use following patch on my Jenkins project to get the bspkrsCore dependency working in DirectionHUD and other mods relying on it

sed -i '
/deobfCompile/ c\
    deobfCompile group: '\''bspkrs'\'', name: '\''bspkrscore'\'', version: project.bscore_version
' build.gradle
sed -i '
/ivy / {N;N;N;N;N;c\
    maven {\
        name = '\''zebra'\''\
        url = '\''https://nexus.3zebras.eu/repository/maven-releases'\''
}' build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants