Extend the ListTransaction api to support queries to "watch only" wallets #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
Jan 9, 2019
| return c.sendCmd(cmd) | ||
| } | ||
|
|
||
| // ListTransactionsCountFromWatchOnly returns a list of the most recent transactions up |
There was a problem hiding this comment.
All columns should be wrapped to 80 characters.
|
@jcvernaleo (as per #1530)
|
Rjected
suggested changes
May 31, 2020
| // to the passed count while skipping the first 'from' transactions including transactions from "watch only" wallets. | ||
| // | ||
| // See the ListTransactions and ListTransactionsCount functions to use defaults. | ||
| func (c *Client) ListTransactionsCountFromWatchOnly(account string, count, from int) ([]btcjson.ListTransactionsResult, error) { |
There was a problem hiding this comment.
I think the signature should include the bool to be consistent with other commands we implement which have optional bools.
|
Done with #1628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ListTransactionsapi doesn't support any methods where including watch only wallets are set to true. This PR adds an api call with that option.