Added ListSinceBlockMinConfWatchOnly method.

[nalcheg]

Added method for request ListSinceBlock with include_watchonly=true

[jakesylvestre]

@jcvernaleo (as per #1530)

• Low priority
• Enhancement

[onyb]

This probably won't work if you want to do something like list all watch-only transactions with the following call:

ListSinceBlockMinConfWatchOnlyAsync(nil, 1, true)

Here's a workaround, although I'm not sure if it's the best solution.

Suggested change

	}
	} else {
	hash = btcjson.String("")
	}

[onyb]

Thanks to #1594, we may not need to do this. Could you please verify this on your side?

[nalcheg]

did in #1163

[onyb]

@nalcheg #1163 is not doing the same thing. You added ListSinceBlockMinConfWatchOnlyAsync. That one was about ListTransactionsCountFromWatchOnlyAsync.

[nalcheg]

sorry, I was wrong

[onyb]

Needs a rebase + the small test I suggested.

[coveralls]

Pull Request Test Coverage Report for Build 245646585

• 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 53.684%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rpcclient/wallet.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
database/ffldb/blockio.go	4	92.62%

Totals
Change from base Build 245421206:	-0.02%
Covered Lines:	20634
Relevant Lines:	38436

---

💛 - Coveralls

[onyb]

Could you please add the following unit-test to walletsvrcmds_test.go? (line 710)

		{
			name: "listsinceblock pad null",
			newCmd: func() (interface{}, error) {
				return btcjson.NewCmd("listsinceblock", "null", 1, false)
			},
			staticCmd: func() interface{} {
				return btcjson.NewListSinceBlockCmd(nil, btcjson.Int(1), btcjson.Bool(false))
			},
			marshalled: `{"jsonrpc":"1.0","method":"listsinceblock","params":[null,1,false],"id":1}`,
			unmarshalled: &btcjson.ListSinceBlockCmd{
				BlockHash:           nil,
				TargetConfirmations: btcjson.Int(1),
				IncludeWatchOnly:    btcjson.Bool(false),
			},
		},

[onyb]

Looks great! Thanks for your contribution.

[jcvernaleo]

OK