Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add addressesMtx to fix race condition #1488

Merged
merged 1 commit into from
Nov 9, 2019
Merged

server: add addressesMtx to fix race condition #1488

merged 1 commit into from
Nov 9, 2019

Conversation

Crypt-iQ
Copy link
Collaborator

@Crypt-iQ Crypt-iQ commented Nov 9, 2019

Running with the race detector gave this.
Two goroutines were accessing the knownAddresses map on a serverPeer object:

==================
WARNING: DATA RACE
Read at 0x00c01cf18450 by goroutine 37:
  runtime.mapaccess2_faststr()
      /usr/local/Cellar/go/1.13/libexec/src/runtime/map_faststr.go:107 +0x0
  main.(*serverPeer).pushAddrMsg()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:315 +0x14b
  main.(*server).handleAddPeerMsg()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:1651 +0xce4
  main.(*server).peerHandler()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:2116 +0xbff

Previous write at 0x00c01cf18450 by goroutine 53:
  runtime.mapassign_faststr()
      /usr/local/Cellar/go/1.13/libexec/src/runtime/map_faststr.go:202 +0x0
  main.(*serverPeer).addKnownAddresses()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:309 +0xbd
  main.(*serverPeer).OnAddr()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:1279 +0x15f
  main.(*serverPeer).OnAddr-fm()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:1242 +0x55
  github.com/btcsuite/btcd/peer.(*Peer).inHandler()
      /Users/nsa/go/src/github.com/btcsuite/btcd/peer/peer.go:1394 +0x2038

Goroutine 37 (running) created at:
  main.(*server).Start()
      /Users/nsa/go/src/github.com/btcsuite/btcd/server.go:2321 +0x1aa
  main.btcdMain()
      /Users/nsa/go/src/github.com/btcsuite/btcd/btcd.go:162 +0x1100
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  github.com/btcsuite/goleveldb/leveldb.(*DB).checkAndCleanFiles()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db_util.go:52 +0x2da
  github.com/btcsuite/goleveldb/leveldb.openDB()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db.go:129 +0xaa1
  fmt.(*ss).doScanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:1217 +0x382
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:370 +0x2c4
  github.com/btcsuite/goleveldb/leveldb.(*DB).recoverJournal()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db.go:475 +0xa7
  github.com/btcsuite/goleveldb/leveldb.openDB()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db.go:124 +0xa7d
  github.com/btcsuite/goleveldb/leveldb.Open()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db.go:196 +0x1c6
  fmt.(*ss).doScanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:1217 +0x382
  fmt.Fscanf()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:143 +0xcf
  github.com/btcsuite/goleveldb/leveldb/storage.fsParseName()
      /usr/local/Cellar/go/1.13/libexec/src/fmt/scan.go:114 +0x192
  github.com/btcsuite/goleveldb/leveldb/storage.(*fileStorage).GetMeta()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/storage/file_storage.go:578 +0x172a
  github.com/btcsuite/goleveldb/leveldb.(*session).recover()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/session.go:116 +0xd9
  github.com/btcsuite/goleveldb/leveldb.Open()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db.go:182 +0xf8
  github.com/btcsuite/goleveldb/leveldb.OpenFile()
      /Users/nsa/go/pkg/mod/github.com/btcsuite/[email protected]/leveldb/db.go:218 +0xa5
  github.com/btcsuite/btcd/database/ffldb.openDB()
      /Users/nsa/go/src/github.com/btcsuite/btcd/database/ffldb/db.go:2009 +0x189
  github.com/btcsuite/btcd/database/ffldb.openDBDriver()
      /Users/nsa/go/src/github.com/btcsuite/btcd/database/ffldb/driver.go:52 +0xf7
  github.com/btcsuite/btcd/database.Open()
      /Users/nsa/go/src/github.com/btcsuite/btcd/database/driver.go:88 +0x102
  main.loadBlockDB()
      /Users/nsa/go/src/github.com/btcsuite/btcd/btcd.go:274 +0x4e4
  main.btcdMain()
      /Users/nsa/go/src/github.com/btcsuite/btcd/btcd.go:102 +0x479
  main.main()
      /Users/nsa/go/src/github.com/btcsuite/btcd/btcd.go:330 +0xeb

Goroutine 53 (running) created at:
  github.com/btcsuite/btcd/peer.(*Peer).start()
      /Users/nsa/go/src/github.com/btcsuite/btcd/peer/peer.go:2153 +0x370
  github.com/btcsuite/btcd/peer.(*Peer).AssociateConnection.func1()
      /Users/nsa/go/src/github.com/btcsuite/btcd/peer/peer.go:2188 +0x3c
==================

Roasbeef
Roasbeef approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

LGTM 🌜

@Roasbeef Roasbeef merged commit 79943b2 into btcsuite:master Nov 9, 2019
@Crypt-iQ Crypt-iQ deleted the server_race_1108 branch November 9, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crypt-iQ @Roasbeef