Add fundrawtransaction RPC call

[torkelrogstad]

As mentioned in #1500

[Rjected]

This registers the command for btcjson and rpcclient, so one can issue these commands, but it does not actually expose the command externally, and I wouldn't call this complete without adding that functionality.

[torkelrogstad]

This registers the command for btcjson and rpcclient, so one can issue these commands, but it does not actually expose the command externally, and I wouldn't call this complete without adding that functionality.

Are you talking about this line?

btcd/btcjson/chainsvrcmds.go

Line 824 in 0668071

MustRegisterCmd("fundrawtransaction", (*FundRawTransactionCmd)(nil), flags)

That is necessary for the RPC client to call this method. You're right in that this is a client-side implementation of the RPC, not server-side. My use case is using the RPC client against a Bitcoin Core backend. If there's a better way of doing a client-only implementation I'm happy to change this, but I think this is the correct way of implementing a client-only RPC.

[Rjected]

This registers the command for btcjson and rpcclient, so one can issue these commands, but it does not actually expose the command externally, and I wouldn't call this complete without adding that functionality.

Are you talking about this line?

btcd/btcjson/chainsvrcmds.go

Line 824 in 0668071

MustRegisterCmd("fundrawtransaction", (*FundRawTransactionCmd)(nil), flags)

That is necessary for the RPC client to call this method. You're right in that this is a client-side implementation of the RPC, not server-side. My use case is using the RPC client against a Bitcoin Core backend. If there's a better way of doing a client-only implementation I'm happy to change this, but I think this is the correct way of implementing a client-only RPC.

I was just referring to the fact that it was client only, and I guess more determining the scope of the PR, this is the correct way to implement client-only. Definitely put up an issue for server side because I think it's sort of a problem to have discrepancies in the supported commands for the client and server for too long.

[Rjected]

@torkelrogstad mind seeing if you can rebase to get the github actions to run?

[torkelrogstad]

Rebased.

[jcvernaleo]

OK