-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcclient: Add getblockfilter JSON-RPC client command #1579
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,3 +75,11 @@ func String(v string) *string { | |
*p = v | ||
return p | ||
} | ||
|
||
// NewFilterTypeName is a helper routine that allocates a new FilterTypeName value to store v and | ||
// returns a pointer to it. This is useful when assigning optional parameters. | ||
func NewFilterTypeName(v FilterTypeName) *FilterTypeName { | ||
p := new(FilterTypeName) | ||
*p = v | ||
return p | ||
} | ||
Comment on lines
+81
to
+85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was about to comment that it might make sense to make the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wasn't super happy about adding helper for this but it allows using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally add the following comment whenever there are optional arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right on. Added these.