btcjson,rpcclient: add support for PSBT commands to rpcclient #1596
Conversation
federicobond
force-pushed
the
psbt
branch
2 times, most recently
from
46b0594
to
1ee0001
Compare
|
Hello, you'll need to fix the CI issues in order for this to get reviewed and merged. Thanks for the contribution! |
|
@Rjected thanks for the heads up! Yeah, its weird though, I could not find out what exactly is it complaining about, the file appears formatted correctly. |
|
Hey, sorry for getting back so late. Here are the changes you'd need to do to fix the formatting issues: Rjected@23478ac . There are also now some conflicts, make sure those are fixed as well and then we can start reviewing! |
|
Ah, that makes sense. Thanks for the heads up. |
|
This is now ready for review. |
There was a problem hiding this comment.
Nice work on the PR!
Most of my remarks are about types. Please also feel free to pull in some descriptions from Bitcoin Core docs wherever relevant. It doesn't need to be an exact copy, but just enough to guide the users and show it beautifully on pkg.go.dev.
|
I'm wondering if btcd/btcjson/btcwalletextcmds.go Lines 5 to 6 in d2b1a06 Compare that to Lines 5 to 6 in d2b1a06 Using |
federicobond
force-pushed
the
psbt
branch
2 times, most recently
from
83e5cef
to
bec3737
Compare
|
I moved the PSBT methods to |
federicobond
force-pushed
the
psbt
branch
3 times, most recently
from
507b6fc
to
08000bc
Compare
btcjson/walletsvrcmds.go
Outdated
| var ( | ||
| SighashAll SighashType = "ALL" | ||
| SighashNone SighashType = "NONE" | ||
| SighashSingle SighashType = "SINGLE" | ||
| SighashAllAnyoneCanPay SighashType = "ALL|ANYONECANPAY" | ||
| SighashNoneAnyoneCanPay SighashType = "NONE|ANYONECANPAY" | ||
| SighashSingleAnyoneCanPay SighashType = "SINGLE|ANYONECANPAY" | ||
| ) |
There was a problem hiding this comment.
Would be nice to have comments here as well.
There was a problem hiding this comment.
Actually, I just noticed that rpcclient already defines a SigHashType type. I think it will be more clear to use that and then convert to *string for the btcjson constructors (to avoid a circular import). This is consistent with the behaviour of SignRawTransaction.
There was a problem hiding this comment.
SigHashType should've really been in btcjson package. But there's nothing we can do about it now, without introducing a breaking change. Let's keep it for later.
federicobond
force-pushed
the
psbt
branch
2 times, most recently
from
6f1c59e
to
87e49cd
Compare
|
Fixed the conflicts, should be ready to merge. |
| ) (*btcjson.WalletProcessPsbtResult, error) { | ||
| return c.WalletProcessPsbtAsync(psbt, sign, sighashType, bip32Derivs).Receive() | ||
| } | ||
|
|
||
| // TODO(davec): Implement |
There was a problem hiding this comment.
might make sense to remove these in favor of issues, but not germane to this review
No description provided.