Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcjson: add test for null params in searchrawtransactions #1635

Merged
merged 1 commit into from
Sep 21, 2020
Merged

btcjson: add test for null params in searchrawtransactions #1635

merged 1 commit into from
Sep 21, 2020

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented Sep 17, 2020

This is about the bug originally reported in #1476. In fact, the fix has been made redundant thanks to support for nullable JSON-RPC params introduced in #1594. This PR simply adds a unit test as proof that the said bug is no longer valid.

@coveralls
Copy link

coveralls commented Sep 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 260158906

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 53.592%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.18%
Totals Coverage Status
Change from base Build 259383636: 0.003%
Covered Lines: 20672
Relevant Lines: 38573
💛 - Coveralls

@onyb onyb force-pushed the searchrawtransactionsverbose-null-test branch from 49f4cf2 to 368024e Compare September 17, 2020 22:21
@onyb onyb added the rpc label Sep 17, 2020
@onyb onyb added this to the 0.22.0 milestone Sep 17, 2020
ipriver
ipriver approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@ipriver ipriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test works. LGTM 👍

jcvernaleo
jcvernaleo approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit f402416 into btcsuite:master Sep 21, 2020
@onyb onyb deleted the searchrawtransactionsverbose-null-test branch September 21, 2020 14:06
@onyb onyb mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@ipriver ipriver ipriver approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@onyb @coveralls @jcvernaleo @ipriver