Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: implement getwalletinfo command #1638

Merged
merged 1 commit into from
Sep 25, 2020
Merged

rpcclient: implement getwalletinfo command #1638

merged 1 commit into from
Sep 25, 2020

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented Sep 21, 2020

Note to the reviewers:

@coveralls
Copy link

coveralls commented Sep 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 265755323

  • 12 of 37 (32.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 53.591%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcjson/walletsvrresults.go 12 19 63.16%
rpcclient/wallet.go 0 18 0.0%
Totals Coverage Status
Change from base Build 265195639: 0.02%
Covered Lines: 20744
Relevant Lines: 38708
💛 - Coveralls

@onyb onyb added the rpc label Sep 22, 2020
@onyb onyb added this to the 0.22.0 milestone Sep 22, 2020
@jakesylvestre
Copy link
Collaborator

LGTM!

@jakesylvestre jakesylvestre merged commit e9a51e8 into btcsuite:master Sep 25, 2020
@jakesylvestre jakesylvestre mentioned this pull request Sep 25, 2020
Open
@onyb onyb deleted the getwalletinfo branch September 26, 2020 18:26
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesylvestre jakesylvestre jakesylvestre approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@onyb @coveralls @jakesylvestre