Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: add more wallet commands #1645

Merged
merged 1 commit into from
Oct 26, 2020
Merged

rpcclient: add more wallet commands #1645

merged 1 commit into from
Oct 26, 2020

Conversation

torkelrogstad
Copy link
Contributor

Implement backupwallet, dumpwallet, loadwallet and unloadwallet.

@coveralls
Copy link

coveralls commented Oct 6, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 297467423

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 12 of 62 (19.35%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 53.455%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/wallet.go 0 50 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.18%
Totals Coverage Status
Change from base Build 289529546: -0.05%
Covered Lines: 20794
Relevant Lines: 38900
💛 - Coveralls

@onyb onyb added the rpc label Oct 6, 2020
onyb
onyb requested changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs some cosmetic changes.

btcjson/walletsvrcmds.go Outdated Show resolved Hide resolved
rpcclient/wallet.go Show resolved Hide resolved
@torkelrogstad
Copy link
Contributor Author

@onyb I've addressed your comments.

@onyb onyb mentioned this pull request Oct 9, 2020
Merged
onyb added a commit to onyb/btcd that referenced this pull request Oct 10, 2020
@onyb
for btcsuite#1645: optional wallet name in UnloadWallet
bcaf380
onyb
onyb requested changes Oct 10, 2020
View reviewed changes
Copy link
Collaborator

@onyb onyb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous review was not so thorough, so here's a second pass.

rpcclient/wallet.go Outdated Show resolved Hide resolved
rpcclient/wallet.go Outdated Show resolved Hide resolved
rpcclient/wallet.go Outdated Show resolved Hide resolved
@jcvernaleo
Copy link
Member

Agreed with @onyb's comments then this one will be good to go in.

@torkelrogstad
rpcclient: add more wallet commands
2f12fc0 
Implement backupwallet, dumpwallet, loadwallet and unloadwallet.
@torkelrogstad
Copy link
Contributor Author

@onyb @jcvernaleo I've addressed your comments!

@onyb onyb added this to the 0.22.0 milestone Oct 22, 2020
jcvernaleo
jcvernaleo approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now!
OK

@jcvernaleo jcvernaleo merged commit 1d75e0a into btcsuite:master Oct 26, 2020
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@torkelrogstad @coveralls @jcvernaleo @onyb