Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: add ExtraHeaders in ConnConfig #1669

Merged
merged 1 commit into from
Nov 24, 2020
Merged

rpcclient: add ExtraHeaders in ConnConfig #1669

merged 1 commit into from
Nov 24, 2020

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Nov 20, 2020 •
edited
Loading

Add ExtraHeaders in ConnConfig struct. It's useful when RPC provider need customized headers. For example, blockdaemon require the header X-Auth-Token.

@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 374125260

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 53.425%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/infrastructure.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 1 75.79%
btcec/signature.go 3 92.48%
database/ffldb/blockio.go 4 92.62%
Totals Coverage Status
Change from base Build 362527469: 0.01%
Covered Lines: 20837
Relevant Lines: 39002
💛 - Coveralls

@onyb onyb added the rpc label Nov 20, 2020
jcvernaleo
jcvernaleo approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Looks good to me.

Will leave open a bit in case anyone else wants to chime in though.

@jcvernaleo jcvernaleo merged commit 610bb55 into btcsuite:master Nov 24, 2020
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@onyb onyb onyb approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@10gic @coveralls @jcvernaleo @onyb