Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcjson (client): Update fields in GetBlockChainInfoResult #1676

Merged
merged 1 commit into from
Jan 26, 2021
Merged

btcjson (client): Update fields in GetBlockChainInfoResult #1676

merged 1 commit into from
Jan 26, 2021

Conversation

skreuzer
Copy link
Contributor

@skreuzer skreuzer commented Jan 3, 2021

Update the fields of GetBlockChainInfoResult to reflect the current state of
the RPC returned by other full-node implementations.

  • InitialBlockDownload - Node is in Initial Block Download mode if True.
  • SizeOnDisk - The estimated size of the block and undo files on disk.

@skreuzer
btcjson: Update fields in GetBlockChainInfoResult
d3e1883 
Update the fields of GetBlockChainInfoResult to reflect the current state of
the RPC returned by other full-node implementations.

 * InitialBlockDownload - Node is in Initial Block Download mode if True.
 * SizeOnDisk - The estimated size of the block and undo files on disk.
@coveralls
Copy link

coveralls commented Jan 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 458547543

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.7%) to 53.389%
Files with Coverage Reduction New Missed Lines %
btcec/signature.go 3 92.48%
database/ffldb/blockio.go 4 92.62%
peer/peer.go 11 76.1%
Totals Coverage Status
Change from base Build 407350020: 1.7%
Covered Lines: 20832
Relevant Lines: 39019
💛 - Coveralls

@skreuzer skreuzer mentioned this pull request Jan 3, 2021
Open
@jakesylvestre jakesylvestre self-requested a review January 18, 2021 18:55
@jakesylvestre jakesylvestre changed the title btcjson: Update fields in GetBlockChainInfoResult btcjson (client): Update fields in GetBlockChainInfoResult Jan 26, 2021
jcvernaleo
jcvernaleo approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
OK

@jakesylvestre jakesylvestre merged commit 7bbd9b0 into btcsuite:master Jan 26, 2021
@jakesylvestre jakesylvestre mentioned this pull request Jan 26, 2021
Open
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesylvestre jakesylvestre jakesylvestre approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skreuzer @coveralls @jcvernaleo @jakesylvestre