txscript: More memory efficient CalcSignatureHash #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of receiving a byte slice as the argument, this new function receives a hash.Hash, giving the option for callers to write directly into a hash and save on the byte slice allocation.
This new calcSignatureHash function behaves more like the calcWitnessSigHash function, which was more memory efficient as it didn't create a temporary tx just to use the tx serialize function that already existed. This results in significant memory savings that show up on pprof.
Changes up calcWitnessSignatureHash to use the DoubleHashBRaw function, saving on the byte slice allocation that would have happened otherwise.
kcalvinalvin
force-pushed
the
btcd-calcsighash-optimizations
branch
from
ffcf709
to
50f8996
Compare
Pull Request Test Coverage Report for Build 1078925121
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done (in order of the commits)
1:
DoubleHashBRaw()function is introduced, just takes in a hash.Hash object directly, allowing callers to save on the byte slice allocation that would have happened otherwise.2:
writeOutPoint()was exported. This is needed for the next commit.3:
CalcSignatureHash()was modified to not have atxCopy, saving the memory allocation for that.4:
CalcSignatureHash()andCalcWitnessSignatureHash()now usesDoubleHashBRaw()instead ofDoubleHashB().In my testing, the memory savings were worth the changes. But this is a pretty insignificant change without #1684