Revert "reduce redundant memory allocatio - resolves btcsuite/btcd#1699" #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 780cc08.
Pull Request Test Coverage Report for Build 1797030693
💛 - Coveralls |
Roasbeef
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
LGTM 🌳
Confirmed that this breaks Tor resolution as is, and this PR resolves things. The issue is that 2 bytes are used for the port (with only one explicitly set), so it's 7 bytes total. We should also update the method to be able to parse a response that's an IPv6 address. I'll make an issue to track that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 780cc08.
Oversight on my part, that extra byte is actually used. Without this, DNS resolution via tor proxy won't work