Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes coveralls coverage report #1814

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

vpereira01
Copy link
Contributor

@vpereira01 vpereira01 commented Feb 22, 2022

With PR #1785 multiple coverage reports are sent to coveralls. This makes coveralls only consider the last report sent. This fix treat all reports has parallel coverage reports so they can all be compiled later by coveralls.

Coverage and after before

@vpereira01 vpereira01 marked this pull request as ready for review February 22, 2022 16:53
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This
makes coveralls only consider the last report sent. This fix treat all
reports has parallel reports so they can all be compiled later by coveralls.
@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 1882749554

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.6%) to 53.291%

Totals Coverage Status
Change from base Build 1896270968: -16.6%
Covered Lines: 23691
Relevant Lines: 44456

💛 - Coveralls

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

OK

@jcvernaleo
Copy link
Member

Sorry for the slow response time on this PR. Reviewed and merging it now.

@jcvernaleo jcvernaleo self-assigned this Mar 10, 2022
@jcvernaleo jcvernaleo added the bug label Mar 10, 2022
@jcvernaleo jcvernaleo merged commit 10cff87 into btcsuite:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants