build: switch to using Go 1.18 for CI in go.mod #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we switch to using Go 1.18 everywhere. This is a deviation from our typical "last 2 versions" rule. Switching now gives us access to the new type params feature immediately, versus near the end of this year. With this change we'd also be able to start using the new std lib fuzzing features as well.
|
This needs a change in the Makefile as well, since |
go get is no longer used to install or build things. Use go install instead. Also specify a version so the module's go.mod is not touched when installing the CI tools.
Pull Request Test Coverage Report for Build 2234921126
💛 - Coveralls |
|
So decided to hold off on this for a bit, influenced by comments from @chappjc. I updated that usage in the musig2 PR to be as compact at the call site as it would be w/ generics, but at the cost of some added function definitions. |
|
Holding off on this for now, as we need to decide on a process for deciding when to update the Go version pinned for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we switch to using Go 1.18 everywhere. This is a
deviation from our typical "last 2 versions" rule. Switching now gives
us access to the new type params feature immediately, versus near the
end of this year. With this change we'd also be able to start using the
new std lib fuzzing features as well.