-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btcec/schnorr/musig2: update to musig 1.0.0 #1894
Merged
Merged
Commits on Oct 21, 2022
-
btcec/schnorr/musig2: update musig2 impl to version 0.7.0
The two _concrete_ changes between version 0.4.0 (where we are before this commit), and version 0.7.0 are: 1. Variable length messages are now allowed, this comes with a new 8 byte prefix for the messages. * Our implementation was already using a `[]byte` for the message/hash, so no extra API changes are needed here. 2. The serialization for a blank message and a normal message (for nonce gen) is now distinct. A single byte is added (either 0 or 1) to indicate if a message was passed into nonce generation.
Configuration menu - View commit details
-
Copy full SHA for a34e777 - Browse repository at this point
Copy the full SHA a34e777View commit details -
btcec/schnorr/musig2: update to musig 1.0.0
The major change in musig 1.0.0 is that plain public keys are used as input to key aggregation.
Configuration menu - View commit details
-
Copy full SHA for 1567f20 - Browse repository at this point
Copy the full SHA 1567f20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d9f448 - Browse repository at this point
Copy the full SHA 3d9f448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e55273 - Browse repository at this point
Copy the full SHA 4e55273View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc12483 - Browse repository at this point
Copy the full SHA cc12483View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca28a98 - Browse repository at this point
Copy the full SHA ca28a98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d895bb - Browse repository at this point
Copy the full SHA 5d895bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 323871f - Browse repository at this point
Copy the full SHA 323871fView commit details
Commits on Oct 25, 2022
-
btcec/schnorr/musig2: always pass in priv key for early nonce gen
This helps mitigate an issue discovered in musig2 under certain scenarios: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-October/021000.html.
Configuration menu - View commit details
-
Copy full SHA for eef9fbc - Browse repository at this point
Copy the full SHA eef9fbcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.