Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: create release branch for v0.22.2 to backport block parsing issue #1901

Merged
merged 6 commits into from
Oct 10, 2022
Merged

release: create release branch for v0.22.2 to backport block parsing issue #1901

merged 6 commits into from
Oct 10, 2022

Commits on Oct 10, 2022

  1. wire: remove erroneous witness size check in wire parsing 

    In this commit, we fix a bug that would cause nodes to be unable to
parse a given block from the wire. The block would be properly accepted
if fed in via other mechanisms.

The issue here is that the old checks for the maximum witness size,
circa segwit v0 where placed in the wire package _as well_ as the tx
engine. This check should only be in the engine, since it's properly
gated by other related scrip validation flags.

The fix itself is simple: limit witnesses only based on the maximum
block size in bytes, or ~4MB.
    @Roasbeef
    Roasbeef committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    ae3b9c9 View commit details
    Browse the repository at this point in the history

  2. mempool: export isDust for use in other projects 

    This changes isDust to IsDust so other golang projects (btcwallet
or lnd) can use the precise dust calculation used by btcd.
    @Crypt-iQ @Roasbeef
    Crypt-iQ authored and Roasbeef committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c4e7856 View commit details
    Browse the repository at this point in the history

  3. mempool: introduce GetDustThreshold to export dust limit calculation 

    This commit modifies no behavior and would allow other projects to
retrieve the dust limit for a particular output type before the
amount of the output is known. This is particularly useful in the
Lightning Network for channel negotiation.
    @Crypt-iQ @Roasbeef
    Crypt-iQ authored and Roasbeef committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    f30a73d View commit details
    Browse the repository at this point in the history

  4. mempool: fix linter error

    @Roasbeef
    Roasbeef committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    4f64fe9 View commit details
    Browse the repository at this point in the history

  5. btcec: check if recovered pk is at point of infinity

    @MariusVanDerWijden @Roasbeef
    MariusVanDerWijden authored and Roasbeef committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7446802 View commit details
    Browse the repository at this point in the history

  6. build: bump version to v0.22.2

    @Roasbeef
    Roasbeef committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    ba2fba5 View commit details
    Browse the repository at this point in the history