Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chaincfg: Update checkpoints #1968

Merged
merged 1 commit into from
Apr 20, 2023
Merged

chaincfg: Update checkpoints #1968

merged 1 commit into from
Apr 20, 2023

Conversation

kcalvinalvin
Copy link
Collaborator

The latest checkpoints were from a few years back and hurts ibd. The updated checkpoints are based off of bitcoin core's past assumvalid blocks.

@kcalvinalvin
chaincfg: Update checkpoints
0696701 
The latest checkpoints were from a few years back and hurts ibd.
The updated checkpoints are based off of bitcoin core's past assumvalid
blocks.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4751925350

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 4493914678: 0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4751925350

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 55.27%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 1 86.27%
Totals Coverage Status
Change from base Build 4493914678: -0.002%
Covered Lines: 26649
Relevant Lines: 48216
💛 - Coveralls

guggero
guggero approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified against my own node and also bitcoind's assumevalid PRs.

jcvernaleo
jcvernaleo approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 52ede32 into btcsuite:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kcalvinalvin @coveralls @jcvernaleo @guggero