blockchain+chaincfg: disable retargeting for regtest #1985
Conversation
Pull Request Test Coverage Report for Build 5342782675
💛 - Coveralls |
|
|
||
| // Emulate the same behavior as Bitcoin Core that for regtest there is | ||
| // no difficulty retargeting. | ||
| if b.chainParams.PoWNoRetargeting { |
There was a problem hiding this comment.
Since this is only desired for Regtest (maybe simnet in btcd as well?), how about something like:
if b.chainParams.Name == chaincfg.RegressionNetParams.Name {
instead of introducing a new field in Params?.
There was a problem hiding this comment.
IMO this makes it just way more explicit what's going on. See lightninglabs/neutrino#256 (comment) 😅
|
ACK cf802a0 |
There was a problem hiding this comment.
LGTM. Just a note about the initial objections from @davecgh, but I think the ship has sailed on this since it's what bitcoind does and apps like neutrino need to match.
FWIW simnet does do retargeting, so applications that depend on being able to replicate such behavior can use that in place. |
This commit emulates the behavior of Bitcoin Core introduced in bitcoin/bitcoin#6853 that disables retargeting of the required proof of work for regtest.
guggero
force-pushed
the
pow-no-retargeting
branch
from
cf802a0
to
599d361
Compare
This commit emulates the behavior of Bitcoin Core introduced in bitcoin/bitcoin#6853 that disables retargeting of the required proof of work for regtest.
Attempts to fix lightninglabs/neutrino#256 in a less hacky way (needs a PR in that repo as well after this one has been merged).