Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcutil: update to chaincfg/chainhash/v1.1.0 #2072

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

Roasbeef
Copy link
Member

This is a follow up to #1978.

We bump to the new chainhash version, then start to use the functionality where applicable.

Next in the sequence is:

  1. Merge this.
  2. Update btcutil/psbt.
  3. Merge that
  4. Update the top-level pacakge (use the two new version above), then merge that.

We'll also want to revisit this PR, as it aims to resolve some of the current module issues that cause PR chains like this each time we update a sub-module: #1825

We also remove the replace directives in place.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7227862106

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 56.073%

Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/gcs/builder/builder.go 0 8 0.0%
Totals Coverage Status
Change from base Build 7227596643: 0.003%
Covered Lines: 27982
Relevant Lines: 49903

💛 - Coveralls

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Roasbeef Roasbeef merged commit 4c2ce6d into btcsuite:master Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants