Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcclient+btcjson: defaultMaxFeeRate to BTC/kvB #2142

Merged
merged 2 commits into from
Apr 3, 2024

Commits on Mar 27, 2024

  1. btcclient+btcjson: feeRate to BTC/kvB

    defaultMaxFeeRate was set to 1e8 / 10(sat/kb) as a parameter.
    But BTC/kvB is the expected value, so the units was wrong.
    This commit updates defaultMaxFeeRate to BTC/kvB and sets it to 0.1,
    which is the default value of Bitcoin Core.
    This commit also updates the comment to reflect the change.
    
    Because maxFeeRate sanity check has been added in
    bitcoin core v27.0 or later,
    sendrawtransaction cannot be executed without this change.
    YusukeShimizu committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bbb6967 View commit details
    Browse the repository at this point in the history
  2. btcclient+btcjson: add type alias for BTC/kvB

    Added type alias BTC/kvB to explicitly indicate that
    it represents the fee in BTC for a transaction size of 1 kB.
    Because bitcoind uses its own fee rate type
    (BTC/kvB instead of sat/kWU we use in lnd),
    define the type in btcjson package,
    as it's the only place where we actually use BTC/kvB.
    YusukeShimizu committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    80b27f5 View commit details
    Browse the repository at this point in the history