Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wtxidrelay message. #2272

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

marcopeereboom
Copy link
Collaborator

This adds support for the wtxidrelay (BIP339) message in wire.

While here, add tests for sendaddrv2 and rename AddrV2Version to SendAddrV2Version in order to make the code consistent with all other messages. This diff does keep the old AddrV2Version constant for backwards compatibility.

This adds support for the wtxidrelay (BIP339) message in wire.

While here, add tests for sendaddrv2 and rename AddrV2Version to
SendAddrV2Version in order to make the code consistent with all other
messages. This diff does keep the old AddrV2Version constant for
backwards compatibility.
@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11703957311

Details

  • 38 of 41 (92.68%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 57.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
peer/peer.go 3 4 75.0%
wire/message.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
txscript/taproot.go 2 95.98%
Totals Coverage Status
Change from base Build 11292783584: 0.02%
Covered Lines: 29878
Relevant Lines: 52201

💛 - Coveralls

@jcvernaleo jcvernaleo self-assigned this Nov 6, 2024
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct.

OK

@jcvernaleo
Copy link
Member

Just waiting on tests then I'll merge.

@marcopeereboom marcopeereboom merged commit 684d64a into master Nov 6, 2024
6 checks passed
@marcopeereboom marcopeereboom deleted the marco/wtxidrelay branch November 6, 2024 13:03
joshuasing pushed a commit to hemilabs/btcd that referenced this pull request Nov 6, 2024
* Add support for wtxidrelay message.

This adds support for the wtxidrelay (BIP339) message in wire.

While here, add tests for sendaddrv2 and rename AddrV2Version to
SendAddrV2Version in order to make the code consistent with all other
messages. This diff does keep the old AddrV2Version constant for
backwards compatibility.

* Bump copyrights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants