hdkeychain: add CloneWithVersion to set custom HD version bytes #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status of getting this merged? It's needed to take advantage of the functionality added in btcsuite/btcd#1617. |
mflaxman
approved these changes
Sep 17, 2020
This adds a new method to the ExtendedKey type that allows cloning the extended key with custom HD version bytes. It does not mutate the original extended key on which the method is called. Added some tests to demonstrate the utility of this method, i.e., conversion between standard and SLIP-0132 extended keys.
|
@mflaxman Thanks for the reminder. Kinda forgot to follow up on this with the other reviewers. Should be quick, since the changes are quite straightforward. |
|
FYI: I open-sourced my hackey code (that doesn't use these pending PRs) if you want to see what a use-case looks like. |
jakesylvestre
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method to the
ExtendedKeytype that allows cloning the extended key with custom HD version bytes. It does not mutate the original extended key on which the method is called.Added some tests to demonstrate the utility of this method, i.e., conversion between standard and
SLIP-0132extended keys.