Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: break FetchInputInfo into two methods #945

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

yyforyongyu
Copy link
Collaborator

This PR breaks FetchInputInfo into two methods, FetchOutpointInfo and FetchDerivationInfo so the caller can better control what to fetch from the wallet db.

@guggero guggero self-requested a review August 8, 2024 14:59
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, makes a lot of sense to make the two queries accessible independently. LGTM pending one variable rename.

wallet/utxos.go Outdated Show resolved Hide resolved
A new method `FetchOutpointInfo` is added to query a given outpoint
without constructing its derivation info.
@guggero guggero merged commit 7d3434c into btcsuite:master Aug 9, 2024
3 checks passed
@yyforyongyu yyforyongyu deleted the fetch-input-info branch August 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants