Handle string properties after computed properties correctly #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the syntax error. I try to fix this and also try to add a fix for this issue this weekend. And BTW: thanks for this great tool! |
it currently compiles to
```js
var obj;
foo(( obj = {}, obj['computed'] = 1, obj.'some-var' = 2, obj ));
```
|
Not the most elegant way to fix this. Any tipps are appreciated. |
|
Thanks for the patch, this looks alright! |
adrianheine
reviewed
Jan 12, 2018
| @@ -175,7 +175,15 @@ export default class ObjectExpression extends Node { | |||
| while (code.original[c] !== ']') c += 1; | |||
| c += 1; | |||
| } | |||
| if (prop.shorthand) { | |||
| if (prop.key.type === 'Literal' && !prop.computed) { | |||
| console.log('' + code) | |||
There was a problem hiding this comment.
I removed that in a follow-up
adrianheine
reviewed
Jan 12, 2018
| prop.key.end + 1, | ||
| '[' + code.slice(prop.start, prop.key.end) + '] = ' | ||
| ); | ||
| console.log('' + code) |
adrianheine
reviewed
Jan 12, 2018
| code.overwrite( | ||
| prop.start, | ||
| prop.key.end + 1, | ||
| '[' + code.slice(prop.start, prop.key.end) + '] = ' |
There was a problem hiding this comment.
I think it would be better to remove the trailing whitespace, since hypothetical whitespace between the colon and the property value would be preserved, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it currently compiles to