Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated ACF Image Support #134

Merged
merged 9 commits into from
Mar 21, 2022
Merged

updated ACF Image Support #134

merged 9 commits into from
Mar 21, 2022

Conversation

felly
Copy link
Contributor

@felly felly commented Nov 25, 2021

This is an update to #123 - credits to @laneparton

I've only changed the bootstrapping of the ACF relevant part to be
fired after the theme is loaded - in case ACF is loaded within the
theme.

Nitpick-CI
Nitpick-CI reviewed Nov 25, 2021
View reviewed changes
src/Plugin.php Outdated Show resolved Hide resolved
@felly
updated ACF Image Support
06a716c 
This is an update to bueltge#123 - credits to @laneparton

I've only changed the bootstrapping of the ACF relevant part to be
fired after the theme is loaded - in case ACF is loaded within the
theme.
widoz
widoz requested changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@widoz widoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested the functionality, just had a look at the code.
Would be nice if we could introduce an Unit Test at least.

src/ACF/Image.php Outdated Show resolved Hide resolved
src/ACF/Image.php Outdated Show resolved Hide resolved
src/Plugin.php Outdated Show resolved Hide resolved
src/Plugin.php Outdated Show resolved Hide resolved
@widoz widoz self-requested a review December 6, 2021 13:28
widoz
widoz requested changes Dec 6, 2021
View reviewed changes
src/ACF/Image.php Show resolved Hide resolved
tests/php/bootstrap.php Outdated Show resolved Hide resolved
Nitpick-CI
Nitpick-CI reviewed Dec 7, 2021
View reviewed changes
src/Plugin.php Outdated Show resolved Hide resolved
Nitpick-CI
Nitpick-CI reviewed Dec 7, 2021
View reviewed changes
src/Plugin.php Outdated Show resolved Hide resolved
widoz
widoz requested changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@widoz widoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felly for all of the effort, I do have some more questions and requests if you don't mind.
Please let me know if you need help on them.

src/Plugin.php Show resolved Hide resolved
src/Plugin.php Outdated Show resolved Hide resolved
tests/php/unit/AdvancedCustomFieldTest.php Outdated Show resolved Hide resolved
@widoz
Copy link
Collaborator

widoz commented Jan 12, 2022

Thank you so much @felly for the PR the effort and the patience in addressing all of the questions. I really appreciate it.

@bueltge To me the PR can be merged, as I said I haven't tested as a normal user but I assume it works as expected.

@widoz widoz requested a review from bueltge January 12, 2022 09:13
@bueltge bueltge merged commit 280bba6 into bueltge:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@widoz widoz widoz requested changes

@Nitpick-CI Nitpick-CI Nitpick-CI left review comments

@bueltge bueltge Awaiting requested review from bueltge

Assignees

@widoz widoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felly @widoz @bueltge @Nitpick-CI @laneparton