Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up messages fix #627

Open
2 tasks done
rasmusei opened this issue Jun 14, 2024 · 10 comments · Fixed by #628 or #636
Open
2 tasks done

Pop-up messages fix #627

rasmusei opened this issue Jun 14, 2024 · 10 comments · Fixed by #628 or #636
Assignees
Labels

Comments

@rasmusei
Copy link

rasmusei commented Jun 14, 2024

AS A Bürokratt Users
I WANT all pop-up messages to be in Estonian and disappear faster
SO THAT I would understand the messages and they would not disturb me

Acceptance Criteria

  • All pop-up notifications should have a timeout. Messages should disappear after 2 seconds.
  • All pop-up title and the content of the messages should only in Estonian and not mixed with English
@1AhmedYasser
Copy link
Collaborator

@baha-a needs to be addressed in header package as well as part of the header task

@jaX10bt
Copy link
Collaborator

jaX10bt commented Jul 16, 2024

Pop-up notifications have a correct timeout but some pop-ups are still partially in English.

Image
image
image

@turnerrainer turnerrainer assigned Fossur and unassigned jaX10bt Aug 1, 2024
@joonasroosalung
Copy link
Contributor

@Fossur Green toasts are seemingly already translated, "Request failed with status code" comes from axios and therefore should be editable in api.ts

@Fossur
Copy link
Contributor

Fossur commented Aug 7, 2024

The notifications seem to come from Training Module instead of Buerokratt Chatbot, should the label be moved?

@turnerrainer turnerrainer transferred this issue from buerokratt/Buerokratt-Chatbot Aug 8, 2024
@Fossur
Copy link
Contributor

Fossur commented Aug 8, 2024

#628

@jaX10bt
Copy link
Collaborator

jaX10bt commented Aug 21, 2024

Some pop-up messages are still in English.

Image

@joonasroosalung
Copy link
Contributor

Presumably issue still exists in Buerokratt-Chatbot and Analytics-Module, need to update api.ts etc in a similar fashion

@joonasroosalung
Copy link
Contributor

@turnerrainer first PR in Buerokratt-Chatbot buerokratt/Buerokratt-Chatbot#843
To come - similar changes in Analytics-Module, Training-Module

joonasroosalung added a commit to joonasroosalung/Training-Module that referenced this issue Aug 23, 2024
@joonasroosalung
Copy link
Contributor

joonasroosalung added a commit to joonasroosalung/Training-Module that referenced this issue Aug 23, 2024
rasmusei pushed a commit that referenced this issue Aug 26, 2024
#636)

* feat: put all axios instances to single api file to reuse interceptor code, use global notificationErrorMsg translation  #627

* feat: move auth and file api, cleanup api.ts #627
@rasmusei rasmusei assigned KlviG and unassigned joonasroosalung Aug 26, 2024
@KlviG KlviG assigned ffrose and jaX10bt and unassigned KlviG Aug 26, 2024
@rasmusei rasmusei assigned joonasroosalung and unassigned ffrose and jaX10bt Aug 27, 2024
@joonasroosalung
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment