Fix default archive commands for PRs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR.
|
emcfarlane
changed the title
emcfarlane
commented
Jun 4, 2024
| @@ -198,4 +198,6 @@ jobs: | |||
| breaking: false | |||
| push: false | |||
| archive: true | |||
| # On push github.ref_name, on delete github.event.ref_name. | |||
| archive_labels: ${{ github.ref_name }} | |||
There was a problem hiding this comment.
This is for testing, we tests a push then archive to roundtrip the label.
nicksnyder
reviewed
Jun 5, 2024
nicksnyder
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invalid use of
github.ref_namewhich points tomainand not the pull request branch ondeleteevents. We now correctly set the label asgithub.event.ref_namewhich points to the branch.