Fix push with no configured module names #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the config file to determine if a module name is present before trying to push to the remote. On no configured modules skip both push and archive steps.
This comment has been minimized.
This comment has been minimized.
nicksnyder
reviewed
Jun 11, 2024
|
Need to fix multi-module pushes. We should push only named modules. |
emcfarlane
force-pushed
the
ed/readConfig
branch
from
788fdfb
to
9f7e88e
Compare
emcfarlane
commented
Jun 13, 2024
| outputs: | ||
| buf_version: | ||
| description: |- | ||
| Version of the Buf CLI used. |
There was a problem hiding this comment.
This is an unrelated change. Originally planned to use it to read back the version in different locations, but went with passing args. It does seem useful to provide outputs for other actions with the version being used supported by most actions.
nicksnyder
approved these changes
Jun 13, 2024
| const args = ["push", "--error-format", "github-actions"]; | ||
| // Add --exclude-unnamed on buf versions that support the flag. | ||
| if (semver.satisfies(bufVersion, ">=1.33.0")) { |
There was a problem hiding this comment.
when we 1.0 this action, I would be in favor of just bumping the required minimum version of the whole action to 1.33.0 so we can eliminate this check
There was a problem hiding this comment.
Yep, any version bumps we can increase the min version on. Left here to allow for a patch on 0.1.
doriable
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for better push behaviour when unnamed modules are present. The action will now read the
buf.yamlconfig file to check for missing names before running the push or archive steps. With the latest release ofbuf@v.1.33.0 we can now also use the flag--exclude-unnamedto avoid failing push on unnamed modules when multiple modules are present.As a test (and example) see the
test-push-unnamedstep in CI:In addition is the introduction of outputs in the
action.ymlby setting the resolved version ofbuf.