Use buf ls-modules for parsing config #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
doriable
approved these changes
Jul 3, 2024
Comment on lines
+35
to
+38
| const stdout = output.stdout.trim(); | ||
| if (stdout === "") { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
super tiny nit: can trim after the output check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the module name parsing to use
buf ls-modulesnow we havebufat v1.34.0 as a requirement. This also fixes an issue for root named modules, which missed a call toparseModulescausing the module to fail. Added a test to cover the root name case.See bufbuild/buf#3081