Skip to content

Commit

Permalink
GH-689 update readme to fix reference to previous test harness (#713)
Browse files Browse the repository at this point in the history
readme referenced `generate-testdata` which is a previous target in the
makefile & `tests/go.mod` was malformed.
  • Loading branch information
elliotmjackson authored Nov 2, 2022
1 parent 74121c9 commit fe29465
Show file tree
Hide file tree
Showing 3 changed files with 457 additions and 7 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1018,9 +1018,9 @@ docker run --rm \
docker run --rm \
bufbuild/protoc-gen-validate ci

# executes the 'build' & 'generate-testdata' make targets
# executes the 'build' & 'testcases' make targets
docker run --rm \
bufbuild/protoc-gen-validate build generate-testdata
bufbuild/protoc-gen-validate build testcases

# override the entrypoint and interact with the container directly
# this can be useful when wanting to run bazel commands without
Expand Down
4 changes: 2 additions & 2 deletions tests/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ module github.com/envoyproxy/protoc-gen-validate/tests
go 1.12

require (
golang.org/x/net v0.0.0-20220907135653-1e95f45603a7
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
github.com/envoyproxy/protoc-gen-validate v0.6.13
golang.org/x/net v0.1.0
google.golang.org/protobuf v1.28.1
)

Expand Down
Loading

0 comments on commit fe29465

Please sign in to comment.