bazel: @com_github_golang_protobuf version consistency. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump Bazel dep for @com_github_golang_protobuf to 1.0 to match the Gopkg.toml used by the make build. * Use pure Bazel external dep for @com_github_golang_protobuf to avoid having a combination of Bazel dep and vendored files. Signed-off-by: Harvey Tuch <[email protected]>
|
@rodaine as discussed yesterday, this unblocks us. |
rodaine
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Bazel dep for @com_github_golang_protobuf to 1.0 to match the
Gopkg.toml used by the make build.
Use pure Bazel external dep for @com_github_golang_protobuf to avoid
having a combination of Bazel dep and vendored files.
Signed-off-by: Harvey Tuch [email protected]