Add macOS testing to CI #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not quite work yet, there are a multitude of issues with cel-cpp that prevent it from functioning :(
jchadwick-buf
force-pushed
the
test-cross-platform
branch
from
26da4f8
to
3c08b36
Compare
Alfus
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform coverage in CI is valuable for C++ since the toolchains are so variable. This PR should ensure nobody accidentally breaks macOS support.
Windows does not currently work due to cel-cpp issues. I don't think we can put any priority on patching that right now. I think MSVC testing would go a long way to attest that changes are more properly portable, versus GCC and Clang which are fairly similar. Hopefully, we can eventually rectify this. The necessary workflow change is already present in this PR, so once
cel-cppis fixed we just need to addwindows-latestto the matrix. Some day.This PR is one I worked on a long time ago, but got stalled on. I rebased it and cleaned it up since I think it is valuable enough to merge.