Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Migrate off cel.OptCheckStringFormat #44

Closed
akshayjshah opened this issue Sep 8, 2023 · 0 comments · Fixed by #48
Closed

[BUG] Migrate off cel.OptCheckStringFormat #44

akshayjshah opened this issue Sep 8, 2023 · 0 comments · Fixed by #48
Assignees
Labels
Bug Something isn't working

Comments

@akshayjshah
Copy link
Member

cel.OptCheckStringFormat is deprecated, but the recommended alternative doesn't seem to exist. I've filed google/cel-go#837 upstream to clarify; as soon as that issue is resolved, we should migrate to the new API.

@akshayjshah akshayjshah added the Bug Something isn't working label Sep 8, 2023
akshayjshah added a commit that referenced this issue Sep 8, 2023
CI is failing because of a deprecation notice on
`cel.OptCheckStringFormat`, but the recommended alternative doesn't
appear to exist. I've filed google/cel-go#837
upstream to clarify, but for now tests are passing so I think we can
safely bypass this lint error.

I also filed #44 so
that we don't forget to migrate to whichever API is recommended and
remove this bypass.
rodaine pushed a commit that referenced this issue Sep 12, 2023
CI is failing because of a deprecation notice on
`cel.OptCheckStringFormat`, but the recommended alternative doesn't
appear to exist. I've filed google/cel-go#837
upstream to clarify, but for now tests are passing so I think we can
safely bypass this lint error.

I also filed #44 so
that we don't forget to migrate to whichever API is recommended and
remove this bypass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants