Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp.valid evaluator #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonbos
Copy link

@simonbos simonbos commented Oct 20, 2023

See bufbuild/protovalidate#101 for details.

This depends on bufbuild/protovalidate#114 being merged. However, locally I was able to build & run conformance tests using some edits to the Makefile. (After the merge on the main repo, I would best re-generate the generated stubs.)

Note that these changes also fix an OverflowError bug when converting message.Message to celtypes.TimestampType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant