Lookup shared object files correctly in new artefact IDs #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
identifiervariable contains the version as well, looking something like 'com.bugsnag:bugsnag-android:4.x.x'. Therefore we should match by checking whether our collections of identifiers is a substring within the identifier, rather than checking for equality, as otherwise SO files will not be extracted.This has been tested by integrating the plugin into the example project, and running
./gradlew assembleReleaseafter invalidating caches and restarting via Android Studio (to prevent any old SO files from hanging around in the build directory).