Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addition of the local Maven repo for ReactNative into afterEvaluate #366

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

imjoehaines
Copy link
Contributor

Goal

The withPlugin block runs before configuration has been applied. This means that a custom nodeModulesDir won't be present yet and so the default will always be used. Moving this to afterEvaluate ensures that we can use a custom nodeModulesDir if one has been given

Note that this happens before the enabled check so that the Bugsnag React Native package can still be resolved. Otherwise the build fails when BAGP is loaded but disabled

Testing

Tested in a local monorepo setup with hoisting

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the completion of CI & a changelog entry

@imjoehaines imjoehaines merged commit 5fd85e8 into next Feb 16, 2021
@imjoehaines imjoehaines deleted the delay-initialisation branch February 16, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants