Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extracting SO files from bugsnag AARs for library modules #423

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Support extracting SO files from bugsnag AARs for library modules #423

merged 1 commit into from
Sep 6, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Sep 2, 2021 •
edited
Loading

Goal

Supports extracting SO files from bugsnag AARs for library modules. This allows linking against bugsnag's NDK API without requiring users to write their own gradle task.

Changeset

  • Updated usage of ApkVariant and ApkVariantOutput to the parent interfaces BaseVariant and BaseVariantOutput. This will make it easier in future to support uploading from library modules if we decide to do so
  • Logged a warning that library modules do not support uploading mapping files
  • Registered the BugsnagInstallJniLibsTask when in a library module

Testing

  • Created E2E test fixtures that are used to build an app module and a library module which link against bugsnag-android's AARs.
  • Altered E2E tests to verify the expected behaviour.
  • Updated the default AGP version used to run tests locally to 7.0.0

@fractalwrench fractalwrench changed the title add limited support for library modules Support extracting SO files from bugsnag AARs for library modules Sep 2, 2021
@fractalwrench fractalwrench marked this pull request as ready for review September 2, 2021 13:38
lemnik
lemnik approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit eb9d0be into v7/next Sep 6, 2021
@fractalwrench fractalwrench deleted the PLAT-7195/base-types branch September 6, 2021 08:21
@fractalwrench fractalwrench mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @lemnik