Prevent exception when old Moshi version on buildScript classpath #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
remove-default-args
branch
from
52e8f01
to
c6f6767
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
v5.8.0 added default values in these constructor parameters, which compiled to bytecode results in two constructors. This results in Moshi generating a slightly different JsonAdapter class, which needs to use the
DEFAULT_CONSTRUCTOR_MARKERfield to try and find the correct ctor.If a user has a plugin in the buildscript classpath which has a dependency on an old version of Moshi (<1.9.1) then the
DEFAULT_CONSTRUCTOR_MARKERis not present, resulting in aNoSuchFieldErrorbeing thrown.This fixes the issue by avoiding the use of default parameters. The end-user should also update any plugins using an old version of Moshi.
Testing
Manually verified in an example app.