Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalise uuid generation on process manifest task #87

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Finalise uuid generation on process manifest task #87

merged 1 commit into from
Feb 19, 2018

Conversation

fractalwrench
Copy link
Contributor

Finalises UUID generation on process manifest, rather than executing task after.

@kattrali
Copy link
Contributor

What does this improve?

@fractalwrench
Copy link
Contributor Author

@kattrali this moves the execution order of the BugsnagManifestTask so that it completes before the processManifest completes. This means that changes made to the manifest such as build UUID generation are written to the file at the appropriate time. Otherwise the Manifest in the build directory and packaged APK may differ in their contents.

@kattrali kattrali merged commit cabc699 into master Feb 19, 2018
@kattrali
Copy link
Contributor

Makes sense - thanks!

@kattrali kattrali deleted the update-build-uuid-gen branch February 19, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @kattrali