Skip to content
This repository has been archived by the owner on Sep 28, 2018. It is now read-only.

Build project with older version of ndk #20

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Build project with older version of ndk #20

merged 1 commit into from
Jun 15, 2018

Conversation

fractalwrench
Copy link
Contributor

Goal

Builds the project with NDK r16b, which maintains armeabi support - a requirement for users stuck on older versions. This requires a script that downloads the NDK bundle onto the machine. This change also caches gradle to speed up the CI build.

Changeset

Added

  • Gradle caching
  • NDK download bash script

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

Builds the project with NDK r16b, which maintains armeabi support. This requires a script that
downloads the NDK bundle onto the machine.
@fractalwrench fractalwrench requested a review from a team June 15, 2018 13:04
@kattrali kattrali merged commit 684c951 into next Jun 15, 2018
@kattrali kattrali deleted the ndk-ci-update branch June 15, 2018 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants