Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jason <[email protected]>
  • Loading branch information
fractalwrench and lemnik authored Jun 24, 2021
1 parent 93e3a33 commit 0a85e37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ String write(@NonNull JsonStream.Streamable streamable) {
Writer out = new BufferedWriter(new OutputStreamWriter(fos, "UTF-8"));
stream = new JsonStream(out);
stream.value(streamable);
logger.i("Saved unsent payload to disk: " + filename);
logger.i("Saved unsent payload to disk: '" + filename + '\'');
return filename;
} catch (FileNotFoundException exc) {
logger.w("Ignoring FileNotFoundException - unable to create file", exc);
Expand Down Expand Up @@ -168,7 +168,7 @@ void discardOldestFileIfNeeded() {

if (!queuedFiles.contains(oldestFile)) {
logger.w("Discarding oldest error as stored "
+ "error limit reached: " + oldestFile.getPath());
+ "error limit reached: '" + oldestFile.getPath() + '\'');
deleteStoredFiles(Collections.singleton(oldestFile));
files.remove(k);
k--;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ static SeverityReason newInstance(@SeverityReasonType String severityReasonType,
case REASON_LOG:
return new SeverityReason(severityReasonType, severity, false, attrVal);
default:
String msg = "Invalid argument for severityReason: " + severityReasonType;
String msg = "Invalid argument for severityReason: '" + severityReasonType + '\'';
throw new IllegalArgumentException(msg);
}
}
Expand Down

0 comments on commit 0a85e37

Please sign in to comment.